Skip to content

N22: The Process #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 4, 2021
Merged

N22: The Process #646

merged 6 commits into from
Jun 4, 2021

Conversation

setzer22
Copy link
Contributor

@setzer22 setzer22 commented Jun 2, 2021

Added my piece on The Process

Part of #640

@setzer22 setzer22 marked this pull request as draft June 2, 2021 16:33
@setzer22 setzer22 marked this pull request as ready for review June 2, 2021 16:49
@setzer22
Copy link
Contributor Author

setzer22 commented Jun 2, 2021

Ok, I think this is ready for review now 👍

I believe you can you squash the commits during the merge on your side? Or is there something I need to do myself?

17cupsofcoffee
17cupsofcoffee approved these changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We can squash when merging 👍

I was able to squash the GIF a bit more to shave off ~25% of the size - might be worth swapping it out for this one:

the_process

@setzer22
Copy link
Contributor Author

setzer22 commented Jun 2, 2021

Thanks!

I was able to squash the GIF a bit more to shave off ~25% of the size - might be worth swapping it out for this one:

Fine by me! Anything I need to do?

@AngelOnFira
Copy link
Member

All good 💯

@AngelOnFira AngelOnFira merged commit 611fa0b into rust-gamedev:source Jun 4, 2021
@ozkriff ozkriff mentioned this pull request Jun 8, 2021
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@setzer22 @AngelOnFira @17cupsofcoffee